Add Nvidia V100s PCI device definition #2032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new PCI device definition for the Nvidia V100s GPU. The change is straightforward and adds the new device to the stackhpc_gpu_data map in etc/kayobe/stackhpc-compute.yml, which is consistent with how other GPUs are defined. My review includes a minor suggestion to improve code style consistency within the file.
Alex-Welsh
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
MoteHue
approved these changes
Dec 9, 2025
Member
Author
|
CI does nothing to test this. @priteau could you force-merge this one? |
Alex-Welsh
had a problem deploying
to
Leafcloud
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In use at a client site, just a new PCI passthrough GPU option with a slightly different product ID to other V100 models